Change the type of prune_target_size field in model::GetBlockchainInfo from u32 to u64#547
Merged
tcharding merged 3 commits intorust-bitcoin:masterfrom Apr 14, 2026
Conversation
RazorBest
changed the title
RazorBest
force-pushed
the
prune-field-getblockchaininfo-model-u64
branch
from
73e52d7 to
8402eec
Compare
RazorBest
force-pushed
the
prune-field-getblockchaininfo-model-u64
branch
from
8402eec to
b10dc06
Compare
jamillambert
approved these changes
Apr 12, 2026
Collaborator
jamillambert
left a comment
jamillambert
left a comment
There was a problem hiding this comment.
ACK b10dc06
Nice one.
tcharding
approved these changes
Apr 13, 2026
Member
|
Waiting for #549 before merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #544
Manual testing
Before:
Run
git checkout 26e3998a283091abeed33a44a8176ec62c15c4d8(the commit that introduced the integration test). Then:Example:
cargo test --release --features 28_1.This test should fail in the commit it was introduced.
After:
Checkout back to the branch and run the same test again. Now, the test should succeed.