Skip to content

separate feature in electrsd for downloading bitcoin core binaries#559

Open
ulrichard wants to merge 1 commit intorust-bitcoin:masterfrom
AminaBank:feature/electrsd_bitcoind_download
Open

separate feature in electrsd for downloading bitcoin core binaries#559
ulrichard wants to merge 1 commit intorust-bitcoin:masterfrom
AminaBank:feature/electrsd_bitcoind_download

Conversation

@ulrichard
Copy link
Copy Markdown

This is essentially a copy of RCasatta/electrsd#119 solving RCasatta/electrsd#118

@ulrichard ulrichard requested a review from tcharding as a code owner April 20, 2026 09:43
Copy link
Copy Markdown
Member

@tcharding tcharding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK b71214d

To get CI working maybe we need to use the new bitcoind_download feature?

@tcharding
Copy link
Copy Markdown
Member

It would be cool to get this in before the next releases (#560).

@tcharding
Copy link
Copy Markdown
Member

And good to see you @ulrichard, sorry to make you repeat work you already did.

@ulrichard ulrichard force-pushed the feature/electrsd_bitcoind_download branch from b71214d to 26df79c Compare April 21, 2026 08:01
@ulrichard
Copy link
Copy Markdown
Author

No problem with the repeated work. It's a tiny change.
I added the new feature in the CI action, but it looks like the pipeline does not start automatically. And I couldn't find in the logs, why the msrv task that is unrelated to electrs failed.

Copy link
Copy Markdown
Collaborator

@jamillambert jamillambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 26df79c

CI failure is unrelated and fixed in #563. I tested the commit from this PR on top of the fix and it passes CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants