Skip to content

Bump rustls-webpki to patched version in lock files#565

Merged
jamillambert merged 1 commit intorust-bitcoin:masterfrom
tnull:2026-04-bump-rustls-webpki
Apr 23, 2026
Merged

Bump rustls-webpki to patched version in lock files#565
jamillambert merged 1 commit intorust-bitcoin:masterfrom
tnull:2026-04-bump-rustls-webpki

Conversation

@tnull
Copy link
Copy Markdown
Collaborator

@tnull tnull commented Apr 22, 2026

Fixes #567.

RUSTSEC-2026-0104 reports a reachable DoS panic in rustls-webpki versions prior to 0.103.13 when parsing a CRL whose IssuingDistributionPoint.onlySomeReasons extension contains a syntactically valid empty BIT STRING. Bumping the pinned version in both checked-in lock files to 0.103.13 addresses the advisory.

I suggest we leave this one open for another day to check if the cronjob will actually open an issue tonight.

@tnull tnull requested a review from tcharding as a code owner April 22, 2026 10:51
Copy link
Copy Markdown
Collaborator

@jamillambert jamillambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should also update bitreq/Cargo.toml dependency to 0.103.13

@tnull
Copy link
Copy Markdown
Collaborator Author

tnull commented Apr 22, 2026

Should also update bitreq/Cargo.toml dependency to 0.103.13

Ah, right, now amended.

Copy link
Copy Markdown
Collaborator

@jamillambert jamillambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 29f4db5

Copy link
Copy Markdown

@luisschwab luisschwab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 29f4db5

@tcharding
Copy link
Copy Markdown
Member

Maybe this needs rebase to get past CI after the feature guard fixes in #563 but I didn't look too closely.

Copy link
Copy Markdown
Member

@tcharding tcharding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 29f4db5

@tcharding
Copy link
Copy Markdown
Member

tcharding commented Apr 23, 2026

Hey @tnull forgive me for being retarded but I don't know what 'Co-Authored-By: HAL 9000' means. Is that just a funny joke or supposed to be a real thing to say you did this patch with an unamed LLM? (Or is there some tool using this joke for real?)

RUSTSEC-2026-0104 reports a reachable DoS panic in `rustls-webpki`
versions prior to `0.103.13` when parsing a CRL whose
`IssuingDistributionPoint.onlySomeReasons` extension contains a
syntactically valid empty `BIT STRING`. Bumping the pinned version in
both checked-in lock files to `0.103.13` addresses the advisory.

Co-Authored-By: HAL 9000
Signed-off-by: Elias Rohrer <dev@tnull.de>
@tnull tnull force-pushed the 2026-04-bump-rustls-webpki branch from 29f4db5 to fe99e0d Compare April 23, 2026 08:14
@tnull
Copy link
Copy Markdown
Collaborator Author

tnull commented Apr 23, 2026

FTR, we now have confirmation that the cargo audit cronjob works: #567.

I don't know what 'Co-Authored-By: HAL 9000' means. Is that just a funny joke or supposed to be a real thing to say you did this patch with an unamed LLM?

Yes, this one.

Rebased to make CI green.

Copy link
Copy Markdown
Collaborator

@jamillambert jamillambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK fe99e0d

No changes to the patch in this PR

@jamillambert jamillambert merged commit 5b3414f into rust-bitcoin:master Apr 23, 2026
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RUSTSEC-2026-0104: Reachable panic in certificate revocation list parsing

4 participants