bitcoind: extract libexec/bitcoin-node and bin/bitcoin-cli alongside bitcoind#572
Merged
tcharding merged 1 commit intoMay 4, 2026
Conversation
xyephy
requested review from
RCasatta,
jamillambert and
tcharding
as code owners
xyephy
changed the title
libexec/bitcoin-node and bin/bitcoin-cli alongside bitcoindlibexec/bitcoin-node and bin/bitcoin-cli alongside bitcoind
Member
|
Coolio, looks good. Can you run the formatter please mate? |
…ide `bitcoind` Closes rust-bitcoin#566
xyephy
force-pushed
the
2026-04-29-extract-multiprocess-binaries
branch
from
d943b7a to
62f9f2b
Compare
Contributor
Author
I've done that. |
|
Concept ACK, thanks for working on this!
Can relate. I'm working on peer-observer/peer-observer#379 which adds an IPC extractor to interact with a I think this PR can help devs working on multiprocess to avoid taking workarounds for testing |
tcharding
approved these changes
May 4, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build script previously extracted only
bin/bitcoindfrom the downloaded tarball and discarded the rest. Downstream crates that needbin/bitcoin-clior since v30 -the multiprocesslibexec/bitcoin-nodehad to maintain their own download + unpack logic, defeating the point of corepc's auto-download. sv2-apps is one such crate: it carries a manual download + extract + macOS codesigning block specifically to get atlibexec/bitcoin-nodefor-ipcbind=unix.This PR extends the extraction filter to pull
bin/bitcoind,bin/bitcoin-cli, and (when feature30_0+ is enabled)libexec/bitcoin-nodefrom the.tar.gz. The cache-completeness check and the macOS arm64 ad-hoc signing pass are updated to match.Closes #566
Tested
cargo build --features "30_2 download"from a clean cache: all three binaries on disk, allcodesign -vpass,bitcoin-node -regtest -ipcbind=unixcreatesregtest/node.sock.cargo build --features "23_2 download": extractsbitcoind+bitcoin-clionly (nolibexec/bitcoin-nodein pre-v30 tarballs); rebuild cache-hits, no re-download loop.bitcoin-30.2-x86_64-linux-gnu.tar.gzandbitcoin-30.2-arm64-apple-darwin.tar.gz.