bitcoind: add support for v31.0#596
Open
0xB10C wants to merge 1 commit into
Open
Conversation
0xB10C
commented
May 20, 2026
Contributor
Author
There was a problem hiding this comment.
for your convenience https://bitcoincore.org/bin/bitcoin-core-31.0/SHA256SUMS
| download = ["anyhow", "bitcoin_hashes", "flate2", "tar", "bitreq", "zip"] | ||
|
|
||
| latest = ["30_2"] | ||
| latest = ["31_0"] |
Collaborator
There was a problem hiding this comment.
I don't think we should change the latest feature, since v31 is not fully implemented.
Contributor
Author
There was a problem hiding this comment.
Right. Good point. For anyone else wondering what it's missing:
in bitcoind/src/client_versions.rs
#[cfg(feature = "31_0")]
pub use corepc_client::{client_sync::v31::*, types::v31 as vtype};
Contributor
Author
There was a problem hiding this comment.
I went a head and added a comment for the next one.
0xB10C
force-pushed
the
2026-05-bitcoind-v31.0
branch
from
41128fe to
8bb308c
Compare
jamillambert
approved these changes
May 20, 2026
Collaborator
jamillambert
left a comment
jamillambert
left a comment
There was a problem hiding this comment.
ACK 8bb308c
CI failure is unrelated, I'm looking into it.
Collaborator
|
Unrelated CI failure in this PR due to the below error fixed in #597: |
Contributor
|
@0xB10C you can just |
0xB10C
force-pushed
the
2026-05-bitcoind-v31.0
branch
from
8bb308c to
8145739
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a cherry-pick from #586 by @xyzconstant which only adds support for downloading Bitcoin Core v31 to the
bitcoindcrate. My hope is that this is faster and easier to review than the whole of #586.It does not touch the RPC part nor the integration tests - this can be done elsewhere. The bitcoind v31.0 binary is needed in e.g. peer-observer/peer-observer#435 (where I currently work around this with a custom 0xb10c/corepc branch) for the
bitcoin-nodebinary.