Fix to download the correct binary for Apple silicon Macs #71
Conversation
|
Mad! Thanks for the contribution mate. utACK f168d5a I don't have an OSX machine so untested. CI is going to fail with formatting errors. You can use |
|
Glad to help! I'm going to pause on merging for now, I discovered the codesign logic fails on macOS Sequoia due to invalid permissions. Will commit to this PR with a more robust solution once I find something. |
|
Couldn't reproduce the codesign failure after running on a few machines. Probably fine for now given this is how it's done in bitcoin core. I've also run |
|
Can you squash the third patch into the first one and force push please. |
|
Bumping this PR—anything else needed to get this merged? |
|
utACK d692352 Good bump! I looked at this yesterday and misunderstood the status. |
|
I'm going to cut another release shortly so this should be out within a few days. |
…Apple silicon Macs d692352e97f837e8af6249b5d5925917d263f316 fix: codesign the bitcoin binary on mac arm64 (Cliff Syner) f38db552ccd38a520f1fedac62fcf94924e46bcf fix: use arm64 binary for apple silicon (Cliff Syner) Pull request description: Previously, using the (node) crate with the `from_downloaded()` trait would fail on apple silicon with `bad CPU type in executable` Part of the update includes some code-signing, this is necessary for unsigned binaries (like bitcoind) to run on Arm Macs: bitcoin/bitcoin#26694 (comment) ACKs for top commit: tcharding: utACK d692352e97f837e8af6249b5d5925917d263f316 Tree-SHA512: 7e01009622d3c3a16ee296e068bb881a63656eb8e74f3e51249c3079f76cee59822fe28df5023fbe183d4067dd4869fcd3be346a4a664316fb8e27747cc2f6c7
2 participants
Previously, using the (node) crate with the
from_downloaded()trait would fail on apple silicon withbad CPU type in executablePart of the update includes some code-signing, this is necessary for unsigned binaries (like bitcoind) to run on Arm Macs:
bitcoin/bitcoin#26694 (comment)