Skip to content

Conversation

@tcharding
Copy link
Member

@tcharding tcharding commented Jun 29, 2022

Introduce a new configuration for rustfmt. To keep all commits passing
CI do as a single patch the following:

  • Add a rustfmt configuration file copied over from rust-bitcoin.
  • Use new fn_params_layout = "Tall" (replace deprecated fn_args_layout)
  • Update CI to run cargo fmt using the nightly toolchain since we use a
    bunch of unstable options.
  • Run cargo +nightly fmt

@tcharding tcharding force-pushed the 06-29-rustfmt branch 4 times, most recently from a466527 to e051678 Compare June 29, 2022 02:55
@tcharding tcharding force-pushed the 06-29-rustfmt branch 2 times, most recently from 4295b6c to 3863c27 Compare July 27, 2022 01:39
@tcharding tcharding marked this pull request as ready for review July 27, 2022 01:40
@tcharding tcharding force-pushed the 06-29-rustfmt branch 2 times, most recently from b5331c3 to 309b9fe Compare July 27, 2022 01:45
@tcharding tcharding mentioned this pull request Jul 27, 2022
@tcharding tcharding marked this pull request as draft July 27, 2022 02:09
@tcharding tcharding marked this pull request as ready for review July 29, 2022 01:48
@tcharding tcharding force-pushed the 06-29-rustfmt branch 2 times, most recently from 739c529 to 7299d79 Compare August 10, 2022 01:06
@tcharding
Copy link
Member Author

Rebase only, no other changes.

@tcharding tcharding force-pushed the 06-29-rustfmt branch 2 times, most recently from 850820b to 4f1290c Compare October 5, 2022 19:54
@tcharding
Copy link
Member Author

tcharding commented Oct 5, 2022

Rebase (incl. running formatter).

@tcharding
Copy link
Member Author

Gentle bump, can I get a review please crew.

Introduce a new configuration for `rustfmt`. To keep all commits passing
CI do as a single patch the following:

- Add a `rustfmt` configuration file copied over from `rust-bitcoin`.
- Use new `fn_params_layout = "Tall"` (replace deprecated `fn_args_layout`)
- Update CI to run `cargo fmt` using the nightly toolchain since we use a
  bunch of unstable options.
- Run `cargo +nightly fmt`
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK afa5525

@apoelstra apoelstra merged commit 88730a5 into rust-bitcoin:master Feb 28, 2023
@tcharding tcharding deleted the 06-29-rustfmt branch March 1, 2023 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants