Use indices internally instead of &'static str + language #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgeisler
approved these changes
Apr 1, 2021
| /// interpreted in multiple languages, an [Error::AmbiguousLanguages] is | ||
| /// returned, containing the possible languages. | ||
| fn language_of<S: AsRef<str>>(mnemonic: S) -> Result<Language, Error> { | ||
| pub fn language_of<S: AsRef<str>>(mnemonic: S) -> Result<Language, Error> { |
There was a problem hiding this comment.
I think your observation from #10 is still true that you can use the narrower error type here.
Collaborator
Author
There was a problem hiding this comment.
No because here S is a string so it can be an invalid mnemonic. This is the static method used for parsing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change should not break any API, it only adds an extra
Cloneon theword_itermethod.