Enable edition 2018 #26
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two newlines at the end of the file, remove one.
Now that we are on edition 2018 we no longer need the explicit `lib` section in the manifest, it is the same as what is provided by default.
Now that we have bumped the MSRV to Rust 1.41.1 we can update the `rand` dependency (and `rand_core`).
|
Any update on this PR? |
Member
Author
|
This PR is missing change to travis.yaml to use the new MSRV toolchain, thanks @ayrat555 |
Closed
stevenroose
reviewed
Feb 23, 2023
| [dependencies] | ||
| bitcoin_hashes = "0.9.4" | ||
| rand_core = "0.4.0" | ||
| rand_core = "0.6.3" |
Collaborator
There was a problem hiding this comment.
This is a breaking change, right.. We expose the rand_core API
Collaborator
|
(Needs rebase) Why is the rand_code change needed to support newer MSRV/2018? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump the MSRV to 1.41.1 and enable edition 2018. This is the same as what we have been doing across the rust-bitcoin stack.