units: Seal the Integer trait#3724
Merged
apoelstra merged 1 commit intorust-bitcoin:masterfrom Dec 14, 2024
Merged
Conversation
53 tasks
This trait is an internal thing, users should never implement it.
tcharding
force-pushed
the
12-11-seal-integer-trait
branch
from
d9090c5 to
4cccbfd
Compare
tcharding
added
the
API break
Member
|
Yeah, agreed. Easy to unseal if users demand it, but it's not clear that we want them to try "hacking in" their own integer types into our parsing logic. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This trait is an internal thing, users should never implement it.