fix: add sorting to satisfy_helper for sortedmulti#921
Merged
apoelstra merged 1 commit intorust-bitcoin:masterfrom Apr 13, 2026
Merged
fix: add sorting to satisfy_helper for sortedmulti#921apoelstra merged 1 commit intorust-bitcoin:masterfrom
apoelstra merged 1 commit intorust-bitcoin:masterfrom
Conversation
trevarj
force-pushed
the
fix_satisfy_helper_sortedmulti
branch
from
4e58fbd to
fb40743
Compare
This logic was done in sortedmulti_a but accidentally overlooked when refactoring sortedmulti. Wrote a test that proves two differently ordered sortedmulti descriptors produce the same witness.
trevarj
force-pushed
the
fix_satisfy_helper_sortedmulti
branch
from
fb40743 to
3f20a69
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This logic was done in sortedmulti_a but accidentally overlooked when
refactoring sortedmulti.
Wrote a test that proves two differently ordered sortedmulti descriptors produce
the same witness.
Found by Andrew in #915 (comment)