12.x: plan: add Plan::tap_sighash_default accessor#950
Open
evanlinjin wants to merge 1 commit into
Open
Conversation
Backport of rust-bitcoin#949 (target: release-13.x) to the 12.x line. Exposes the existing per-Schnorr-placeholder size assumption — recorded when the plan was built from `TaprootCanSign::sighash_default` — as a single `Option<bool>` on the Plan. Callers constructing a PSBT can use this to populate `PSBT_IN_SIGHASH_TYPE` consistently with the witness-size assumption baked into `Plan::satisfaction_weight`.
This was referenced May 17, 2026
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
12.x backport of #951.
Adds a public accessor on
Planthat exposes the existing per-Schnorr-placeholder size assumption — recorded when the plan was built fromTaprootCanSign::sighash_default— as a singleOption<bool>.See #951 for full rationale and the test.
Test plan
cargo build— clean. (No test added on this backport; covered on plan: add Plan::tap_sighash_default accessor #951.)🤖 Generated with Claude Code