MySQL optional OpenSSL dependency#192
Closed
TobiasDeBruijn wants to merge 2 commits intorust-db:mainfrom
TobiasDeBruijn:main
Closed
MySQL optional OpenSSL dependency#192TobiasDeBruijn wants to merge 2 commits intorust-db:mainfrom TobiasDeBruijn:main
TobiasDeBruijn wants to merge 2 commits intorust-db:mainfrom
TobiasDeBruijn:main
Conversation
Contributor
Author
|
New PR as #202 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refinery depends on MySQL when the
mysqlfeature is enabled, However there is no way to specify the features yet. My PR to rust-mysql-simple adds a feature that allows end users to remove OpenSSL from their dependency tree.This PR adds a feature
mysql-notlstorefinerywhich allows users to explicitly disable TLS support in MySQL, and thus OpenSSL. It does this by:default-features = falsetomysqlinrefinery_coremysql-nativetlstorefinery_corewhich enables the featuremysql/native-tlsmysql-notlstorefinery, which adds themysqldependency inrefinery_coremysqlinrefineryto includerefinery_core/mysql-nativeltsThis approach was chosen to remove backwards compatibility issues for users relying on
refinery. Those that rely onrefinery_coredirectly will however need to enable therefinery_core/myslq-nativetlsfeature to keep native TLS support.This PR should not be merged yet, as the PR linked above has not yet been shipped in a version of
rust-mysql-simple.Any feedback is more than welcome :"D