Skip to content

MySQL optional OpenSSL dependency#192

Closed
TobiasDeBruijn wants to merge 2 commits intorust-db:mainfrom
TobiasDeBruijn:main
Closed

MySQL optional OpenSSL dependency#192
TobiasDeBruijn wants to merge 2 commits intorust-db:mainfrom
TobiasDeBruijn:main

Conversation

@TobiasDeBruijn
Copy link
Contributor

Refinery depends on MySQL when the mysql feature is enabled, However there is no way to specify the features yet. My PR to rust-mysql-simple adds a feature that allows end users to remove OpenSSL from their dependency tree.

This PR adds a feature mysql-notls to refinery which allows users to explicitly disable TLS support in MySQL, and thus OpenSSL. It does this by:

  • Adding default-features = false to mysql in refinery_core
  • Adding feature mysql-nativetls to refinery_core which enables the feature mysql/native-tls
  • Adding feature mysql-notls to refinery, which adds the mysql dependency in refinery_core
  • Modifes feature mysql in refinery to include refinery_core/mysql-nativelts
    This approach was chosen to remove backwards compatibility issues for users relying on refinery. Those that rely on refinery_core directly will however need to enable the refinery_core/myslq-nativetls feature to keep native TLS support.

This PR should not be merged yet, as the PR linked above has not yet been shipped in a version of rust-mysql-simple.

Any feedback is more than welcome :"D

@TobiasDeBruijn
Copy link
Contributor Author

New PR as #202

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant