Updated mysql and disabled default features#202
Merged
jxs merged 6 commits intorust-db:mainfrom Jan 4, 2022
TobiasDeBruijn:mysql-features-optional
Merged
Updated mysql and disabled default features#202jxs merged 6 commits intorust-db:mainfrom TobiasDeBruijn:mysql-features-optional
jxs merged 6 commits intorust-db:mainfrom
TobiasDeBruijn:mysql-features-optional
Conversation
- Bumped mysql to v22.0.0 - Disabled default features on mysql - Added flate2 crate with zlib feature, This previously came in via the mysql crate but now it no longer is, so it must be specified by us
Member
|
Hi, and thanks for your interest! This seems legit, but can we make it so that |
…feature is enabled
jxs
reviewed
Jan 4, 2022
jxs
reviewed
Jan 4, 2022
jxs
reviewed
Jan 4, 2022
jxs
reviewed
Jan 4, 2022
Contributor
Author
|
Good point to also allow |
Member
|
yeah, sorry for the spam fixing the typos also. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Reasoning
MySQL default ships with
native-tls, i.e. OpenSSL enabled by default. My PR to themysqlcrate makes this optional but keeps OpenSSL enabled by default. However, when usingrefineryit is still pulled in, even if it is not enabled in my binary crate due to the way Cargo resolves features.This PR makes
mysqlfeatures optional, allowing the end user to choose if they wantnative-tls, orrustlse.g. By defaultmysqlalso came with the featureflate2/zlib, with disabled default featuresflate2/zlibis no longer included. When usingrefinerywith only themysqlfeature enabled it compiles fine. However, with the default feature set it no longer does (cargo bfails with too many errors to count).Backwards compatibility
Backwards compatibility is maintained as the
OpenSSLfeature is still enabled by default via themysqlcrate.Thanks