-
Notifications
You must be signed in to change notification settings - Fork 68
Add to_slice serialization function #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add to_slice serialization function #36
Conversation
…nto an external buffer, eliminating the need for an additional copy in some cases. Fixes rust-embedded-community#35
eldruin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the nitpick about the variable name, looks good to me, thanks!
|
Also, could you add an entry to the changelog for this? |
|
Also, how does this differ from #27 ? |
|
@eldruin I think you might be right. It looks like they add exactly the same functionality. So i think it is mostly a question of which approach do you like better? |
|
I think this version is simpler so let's merge this one and close #27 |
to_slicefunction when serializing, that allows serialization into an external buffer, eliminating the need for an additional copy in some cases.to_vecto make use of above introducedto_sliceto_stringto make use ofto_vecwith an additional utf8 checkFixes #35