add scroll #31
Merged
add scroll #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
extensible and endian-aware Read/Write traits for generic containers
Contributor
|
@memoryruins This is nice and I don't have any objection adding it but at the moment I also can't think of any use case in embedded. Are there any projects making good use of it? |
Contributor
|
FWIW when I came across this PR, I bookmarked it to try addressing ah-/anne-key#20 with this crate :) |
Contributor
|
@hdhoang Thanks for the feedback. Speaking of which, I really think we should have awesome embedded firmwares also on the list, mind submitting a PR to add anne-key? ;) |
therealprof
approved these changes
Apr 30, 2018
Contributor
therealprof
left a comment
therealprof
left a comment
There was a problem hiding this comment.
LGTM, thanks for your contribution.
Contributor
Author
|
It's a core crate of https://github.com/m4b/goblin (developed by the dev of scroll), which is used in the Redox kernel. Fantastic to see anne-key already checking it out :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scroll: extensible and endian-aware Read/Write traits for generic containers