Skip to content

Add W5500 Ethernet Module Driver #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 16, 2018
Merged

Add W5500 Ethernet Module Driver #56

merged 2 commits into from
Jul 16, 2018

Conversation

@kellerkindt
Copy link
Contributor

@kellerkindt kellerkindt commented Jul 16, 2018

No description provided.

therealprof
therealprof requested changes Jul 16, 2018
View reviewed changes
Copy link
Contributor

@therealprof therealprof left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the description could be improved: While the physical interface is Ethernet, the chip itself contains a hardwired (and IPv4-only) TCP/IP stack which may or may not limit the usefulness so I'd like to see that reflected in the naming somehow.

@kellerkindt
Copy link
Contributor Author

kellerkindt commented Jul 16, 2018

Do you mean like that? Basically the first feature listed in their PDF

therealprof
therealprof approved these changes Jul 16, 2018
View reviewed changes
Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot.

@therealprof therealprof merged commit baf3e47 into rust-embedded:master Jul 16, 2018
@kellerkindt
Copy link
Contributor Author

kellerkindt commented Jul 16, 2018

That was fast 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@therealprof therealprof therealprof approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kellerkindt @therealprof