Skip to content

Add FromIterator implementation for Deque - #684

Open
ollien wants to merge 1 commit into
rust-embedded:mainfrom
ollien:fromiterator-deque
Open

Add FromIterator implementation for Deque#684
ollien wants to merge 1 commit into
rust-embedded:mainfrom
ollien:fromiterator-deque

Conversation

@ollien

@ollien ollien commented Aug 8, 2026

Copy link
Copy Markdown

Fixes #683

I took the simplest possible route of just reusing the Extend implementation

@ollien

ollien commented Aug 8, 2026

Copy link
Copy Markdown
Author

Looks like testcfail is failing on some other branches, too, I don't believe this to be an issue with this PR.

@sgued

sgued commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Looks like testcfail is failing on some other branches, too, I don't believe this to be an issue with this PR.

Please rebase on top of main, #668 includes a fix for the MSRV CI failure.

@ollien
ollien force-pushed the fromiterator-deque branch from ab9f29a to 98e4b98 Compare August 8, 2026 17:59
@ollien

ollien commented Aug 8, 2026

Copy link
Copy Markdown
Author

@sgued Should be good to go!

@sgued

sgued commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Thank you for the PR,

This looks good and in line with the rest of the crate, but I don't really like these implementions, as they make it quite easy to have unintended panics (as you correctly test for thank you). 

We will probably remove them in the next breaking release (see #642 (comment) and #442 for discussions around that).

@ollien

ollien commented Aug 8, 2026

Copy link
Copy Markdown
Author

@sgued That's completely reasonable, I admit I was a bit surprised by the other panics too.

Feel free to close this out if it doesn't align with your plans.

@sgued

sgued commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

I'm not going to close this, but I'm on holidays for a week just FIY, I'll update you then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FromIterator for Deque

2 participants