-
Notifications
You must be signed in to change notification settings - Fork 405
Add EIP-7623 support to evm 1.0
#391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EIP-7623 support to evm 1.0
#391
Conversation
|
For running the tests for pectra, you will need to add Line 181 in 95762b2
If possibly only running the tests for EIP-7623 |
Not sure if this is possible. It passed everything so I didn't yet added any |
| Fork::London => Config::london(), | ||
| Fork::Shanghai => Config::shanghai(), | ||
| Fork::Cancun => Config::cancun(), | ||
| Fork::Prague => Config::prague(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm why is this tests passing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could it be because the EIP-7702 testing is mostly implemented in this framework https://github.com/ethereum/execution-spec-tests (rather then https://github.com/ethereum/tests)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also the https://github.com/ethereum/tests/tree/428f218d7d6f4a52544e12684afbfe6e2882ffbf submodule is pointing to a commit from 2 years ago.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also the https://github.com/ethereum/tests/tree/428f218d7d6f4a52544e12684afbfe6e2882ffbf submodule is pointing to a commit from 2 years ago.
Yeah this is expected. At some point last year, legacy tests are removed from ethereum/tests and replaced by legacytests. Then EIP-7610 is implemented (for all hard forks). The tests of oldethtests and legacytests are actualy redundant to each other. legacytests is simply a newer version of oldethtests, with the only difference of whether it implements EIP-7610.
Mainnet clients don't care, but we still want to support non-EIP-7610 situations, so we still keep oldethtests with a commit from 2 years ago.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some remarks, we should use saturating math operations
| Paris, | ||
| Berlin, | ||
| Cancun, | ||
| Prague, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I think I know -- The commit of legacytests doesn't yet contain any Prague tests. It's up to the last hard fork.
To test Prague we need to update legacytests or add ethereum-spec-tests.
As said in previous comment, on the other hand, oldethtests is used only for EIP-7610 and it should never be updated.
|
@sorpaas for using the merge queue, we need to update the workflows with a |
|
@manuelmauro Please pull master and then we can merge. |
…t-for-eip7623-on-evm-1.0
Description
Adds support for EIP-7623