-
Notifications
You must be signed in to change notification settings - Fork 405
Add EIP-7623 support to evm 1.0
#391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
275c7bd
578ddd0
d4282ec
5d4183b
bb70b38
df6458e
c1f288a
12ebc19
ee3fb27
795e824
f6520d4
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -166,6 +166,7 @@ pub enum Fork { | |
| Paris, | ||
| Berlin, | ||
| Cancun, | ||
| Prague, | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ah I think I know -- The commit of To test As said in previous comment, on the other hand, |
||
| London, | ||
| Merge, | ||
| Shanghai, | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm why is this tests passing?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could it be because the EIP-7702 testing is mostly implemented in this framework https://github.com/ethereum/execution-spec-tests (rather then https://github.com/ethereum/tests)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also the https://github.com/ethereum/tests/tree/428f218d7d6f4a52544e12684afbfe6e2882ffbf submodule is pointing to a commit from 2 years ago.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah this is expected. At some point last year, legacy tests are removed from
ethereum/testsand replaced bylegacytests. Then EIP-7610 is implemented (for all hard forks). The tests ofoldethtestsandlegacytestsare actualy redundant to each other.legacytestsis simply a newer version ofoldethtests, with the only difference of whether it implements EIP-7610.Mainnet clients don't care, but we still want to support non-EIP-7610 situations, so we still keep
oldethtestswith a commit from 2 years ago.