Add Beaver favicon to bors - #782
Conversation
| {% endblock %} | ||
| <title>{% block title %}{% endblock %}</title> | ||
| <link rel="icon" type="image/png" | ||
| href="/assets/img/favicon.ico"/> |
There was a problem hiding this comment.
if it's a png, why is it called .ico? .png works just fine and then GitHub will atually show it. you can downscale the png to make it smaller of course, or use a jpeg or webp
There was a problem hiding this comment.
Sorry, the type there is wrong. IIRC .ico was the only format supported by old browsers, but I guess we can just ignore that and use a modern format these days. I started with web dev a long time ago, and I'm still used to thinking about supporting IE 6/7 and stuff 😆
There was a problem hiding this comment.
I resized the PNG to 48x48 instead of using .ico. It's now 4x smaller than the .ico at the same resolution, lol.
There was a problem hiding this comment.
cool cool! yeah ico is a terrible format :D
3 participants
Suggested in https://rust-lang.zulipchat.com/#narrow/channel/496228-t-infra.2Fbors/topic/favicon/with/609803508.