fix(job_queue): Handle Clippy CLI arguments in fix message

[blyxyas]

fixes #16637

What does this PR try to resolve?

Clippy lints can be enabled via the command line via cargo clippy -- -Wclippy::lint, and these need to be included in the cargo fix command (because if a lint is not emitted, it's not fixed, and some lints are allow-by-default)

---

When cargo clippy is executed, Clippy sets the env. var CLIPPY_ARGS to the arguments that were passed to Clippy, separated by the string __CLIPPY_HACKERY__. To avoid breaking behaviour in between runs (like in fix), we should maintain those arguments.

This PR takes that CLIPPY_ARGS env var (if it exists), replaces the __CLIPPY_HACKERY__ separator and appends it to the suggested cargo clippy --fix command when emitting fixable warnings.

How to test and review this PR?

Via copying a crate (in my case, tokio-1.38.1) and executing the following commands:

rustup run nightly ~/git/cargo/target/debug/cargo clippy -- -Wclippy::pedantic -Aclippy::allow_attributes -Wclippy::dbg_macro -Wclippy::eq_op

In order to get some warnings. If any fixable warning is emitted, the output message should end with:

warning: `tokio` (lib) generated 42 warnings (run `cargo clippy --fix --lib -p tokio -- -Wclippy::pedantic -Aclippy::allow_attributes -Wclippy::dbg_macro -Wclippy::eq_op` to apply 16 suggestions)

Now, testing with the suggested command (in this case, also with the version pinned @1.38.1):

rustup run nightly ~/git/cargo/target/debug/cargo clippy --fix --lib -p tokio@1.38.1 -- -Wclippy::pedantic -Aclippy::allow_attributes -Wclippy::dbg_macro -Wclippy::eq_op

All warnings (including those allow-by-default pedantic lints!) should be fixed now.

[rustbot]

r? @epage

rustbot has assigned @epage.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

• Owners of files modified in this PR: @ehuss, @epage, @weihanglo
• @ehuss, @epage, @weihanglo expanded to ehuss, epage, weihanglo
• Random selection from ehuss, epage, weihanglo

[epage]

Thanks!

[rustbot]

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

[blyxyas]

Sorry for so much force-pushing, but the commit reordering seems to have messed up the git history, so I had to rebase.

[epage]

Thanks!

View changes since this review