Skip to content

Conversation

@Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Nov 29, 2024

This should check a) if publishing without valid authentication fails and b) if HTTP error codes and messages are successfully received and shown by cargo.

Related:

@Turbo87 Turbo87 added C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear A-backend ⚙️ labels Nov 29, 2024
This should check a) if publishing without valid authentication fails and b) if HTTP error codes and messages are successfully received and shown by cargo.
In this case we still want to smoke test the version downloads, but with the latest version instead of the one which we did not publish.
@codecov
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 32 lines in your changes missing coverage. Please review.

Project coverage is 89.45%. Comparing base (dbdd2cd) to head (cfd4e9b).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
crates/crates_io_smoke_test/src/cargo.rs 0.00% 17 Missing ⚠️
crates/crates_io_smoke_test/src/main.rs 0.00% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10104      +/-   ##
==========================================
- Coverage   89.54%   89.45%   -0.10%     
==========================================
  Files         294      294              
  Lines       31224    31256      +32     
==========================================
  Hits        27959    27959              
- Misses       3265     3297      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Turbo87 Turbo87 merged commit e6ec730 into rust-lang:main Nov 29, 2024
10 checks passed
@Turbo87 Turbo87 deleted the smoke-test branch November 29, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant