default_version for publish
#9722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eth3lbert
commented
Oct 22, 2024
There was a problem hiding this comment.
Another approach would be to calculate from all versions. Since TopVersion already needs to calculate from all versions, we could consider pre-sorting the versions and providing methodologies for TopVersion and default_versions to determine values from the sorted versions.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9722 +/- ##
==========================================
- Coverage 88.88% 88.88% -0.01%
==========================================
Files 289 289
Lines 29552 29568 +16
==========================================
+ Hits 26268 26282 +14
- Misses 3284 3286 +2 ☔ View full report in Codecov by Sentry. |
|
☔ The latest upstream changes (presumably #9723) made this pull request unmergeable. Please resolve the merge conflicts. |
eth3lbert
force-pushed
the
default-version-for-publish
branch
from
338ff27 to
095cba4
Compare
Turbo87
reviewed
Oct 22, 2024
Turbo87
added
C-enhancement ✨
eth3lbert
commented
Oct 22, 2024
eth3lbert
force-pushed
the
default-version-for-publish
branch
from
095cba4 to
3d5d899
Compare
Turbo87
reviewed
Oct 22, 2024
eth3lbert
force-pushed
the
default-version-for-publish
branch
from
3d5d899 to
9e6a5d1
Compare
Turbo87
reviewed
Oct 22, 2024
The value is determined by comparing the existing `default_value` to the published version. This could potentially result in upserting an outdated version. A subsequent background job is necessary to ensure correctness and eventual consistency.
eth3lbert
force-pushed
the
default-version-for-publish
branch
from
9e6a5d1 to
a5d24b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we will respond with the
default_versionto the client, this PR always upsert thedefault_valuefor publish.