models/default_version: Implement Ord for Version
#9723
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
added
C-internal 🔧
Turbo87
force-pushed
the
default-versions-ord
branch
from
31c8918 to
f66f6a5
Compare
This allows us to simplify the `find_default_version()` version fn, which now only needs to iterate the slice once instead of up to three times, and it makes it possible to directly compare two `Version` instances too.
Turbo87
force-pushed
the
default-versions-ord
branch
from
f66f6a5 to
7351390
Compare
This removes the need for the `.cloned()` call, since we can use `.into_iter()` now.
Turbo87
force-pushed
the
default-versions-ord
branch
from
7351390 to
9f9992e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9723 +/- ##
==========================================
+ Coverage 88.87% 88.88% +0.01%
==========================================
Files 289 289
Lines 29514 29552 +38
==========================================
+ Hits 26231 26268 +37
- Misses 3283 3284 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to simplify the
find_default_version()version fn, which now only needs to iterate the slice once instead of up to three times, and it makes it possible to directly compare twoVersioninstances too. This should be able to simplify #9722 a little bit.