Automatic prioritization of crates - #714
Merged
Merged
Conversation
jyn514
reviewed
Apr 13, 2020
jyn514
left a comment
jyn514
left a comment
Member
There was a problem hiding this comment.
Thanks for the work on this, it looks really good!
jyn514
reviewed
Apr 13, 2020
emilyalbini
reviewed
Apr 14, 2020
Co-Authored-By: Joshua Nelson <joshua@yottadb.com>
Co-Authored-By: Joshua Nelson <joshua@yottadb.com>
Co-Authored-By: Joshua Nelson <joshua@yottadb.com>
Co-Authored-By: Joshua Nelson <joshua@yottadb.com>
Co-Authored-By: Joshua Nelson <joshua@yottadb.com>
You've tricked me the last time, Jyn. Fool me once, shame on you. Fool me twice... well, it looks like I really am the fool, now aren't I? You, sitting there with your code reviews, adding suggestions "Remove this! Add that! This is critically broken and threatens the stability of our infrastructure!". Well I've had enough. I'm through with your deceit and trickery, for this is the last straw. This is the straw that broke the camel's back, and this camel isn't particularly happy about its back being broken. No, this camel is done with it all! Off with the straw! No longer will I sit here, straw being piled on my back by a malicious taskmaster, breaking my back over pull requests, only to be broken again and again. This is the end, I am free now!
jyn514
approved these changes
Apr 14, 2020
jyn514
left a comment
jyn514
left a comment
Member
There was a problem hiding this comment.
I want to test the CLI behavior locally, but otherwise this looks great :)
jyn514
suggested changes
Apr 14, 2020
Member
|
You can test the CLI changes by running without the CRATESFYI_DATABASE_URL variable set. Currently, it does nothing; it should instead give an error. |
Member
|
Thanks for working on this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
crate_prioritiestable in the databasexnumber of crates inytime get a temporary priority drop