ReferenceNames: Support non-UTF8 branch names#1239
Merged
weihanglo merged 1 commit intorust-lang:masterfrom Apr 28, 2026
Merged
ReferenceNames: Support non-UTF8 branch names#1239weihanglo merged 1 commit intorust-lang:masterfrom
ReferenceNames: Support non-UTF8 branch names#1239weihanglo merged 1 commit intorust-lang:masterfrom
Conversation
Contributor
Author
|
Looks like git won't let you create such a branch on windows or macos (though on Windows I could run Anyway, if this looks good I'll rebase and squash it, we don't need all of these commits in the history |
weihanglo
reviewed
Apr 28, 2026
Member
There was a problem hiding this comment.
This is reasonable. Could you clean up the commit history? No need to strictly follow but this commit structure style is useful: https://epage.github.io/dev/pr-style/#c-atomic
Rather than using `Result::unwrap()` on the result of `str::from_utf8()`, handle failures by converting the `Utf8Error` into a `git2::Error`; the iterator for reference names already returns `Result`s that could be failures, so the signature is unchanged. Add some end-to-end tests to confirm the results. Fixes rust-lang#1175
DanielEScherzer
force-pushed
the
non-utf-branch
branch
from
09c77b4 to
2027edb
Compare
Contributor
Author
Squashed it |
weihanglo
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than using
Result::unwrap()on the result ofstr::from_utf8(), handle failures by converting theUtf8Errorinto agit2::Error; the iterator for reference names already returnsResults that could be failures, so the signature is unchanged.Add some end-to-end tests to confirm the results.
Fixes #1175