Return Result values rather than converting errors to None#1241
Open
DanielEScherzer wants to merge 23 commits intorust-lang:masterfrom
Open
Return Result values rather than converting errors to None#1241DanielEScherzer wants to merge 23 commits intorust-lang:masterfrom
Result values rather than converting errors to None#1241DanielEScherzer wants to merge 23 commits intorust-lang:masterfrom
Conversation
DanielEScherzer
force-pushed
the
return-results
branch
from
b043aae to
b82963e
Compare
Contributor
Author
|
Now that #1239 has been merged, we should probably return |
* `Commit::message()` * `Commit::message_encoding()` * `Commit::message_raw()` * `Commit::raw_header()` * `Commit::summary()` * `Commit::body()`
* `ConfigEntry::name()` * `ConfigEntry::value()`
* `PushUpdate::src_refname()` * `PushUpdate::dst_refname()`
* `Reference::name()` * `Reference::shorthand()` * `Reference::symbolic_target()`
* `Refspec::dst()` * `Refspec::src()` * `Refspec::str()`
* `Remote::name()` * `Remote::url()` * `Remote::pushurl()`
* `Signature::name()` * `Signature::email()`
* `Submodule::branch()` * `Submodule::url()` * `Submodule::name()`
* `Tag::message()` * `Tag::name()`
DanielEScherzer
force-pushed
the
return-results
branch
from
b82963e to
ba8cb90
Compare
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #857