Skip to content

Add end-to-end tests showing use of Repository::statuses()#1251

Merged
weihanglo merged 1 commit into
rust-lang:mainfrom
DanielEScherzer:repo-status-e2e
May 13, 2026
Merged

Add end-to-end tests showing use of Repository::statuses()#1251
weihanglo merged 1 commit into
rust-lang:mainfrom
DanielEScherzer:repo-status-e2e

Conversation

@DanielEScherzer
Copy link
Copy Markdown
Contributor

Specifically how it analyses files and should be used to determine if a repo is "clean".

Closes #1145

Specifically how it analyses files and should be used to determine if a repo is
"clean".

Closes rust-lang#1145
@rustbot rustbot added the S-waiting-on-review Status: Waiting on review label May 12, 2026
Copy link
Copy Markdown
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I don't think this really resolve the confusion of #1145, we at least have a file can point at when confusion arises. Thanks!

View changes since this review

Comment thread tests/end_to_end.rs
std::os::unix::fs::symlink(to, from).unwrap();

#[cfg(windows)]
std::os::windows::fs::symlink_file(to, from).unwrap();
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On windows this requires developer mode privileges btw. If we have already done this, fine, if not, better make this skippable locally and enforced in CI.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't appear to have done this already - not sure how to make it skippable locally and enforced in CI, even though I use a windows machine I do all of my development in docker containers that run linux.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weihanglo weihanglo added this pull request to the merge queue May 13, 2026
Merged via the queue into rust-lang:main with commit 8cce71d May 13, 2026
7 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Waiting on review label May 13, 2026
@DanielEScherzer DanielEScherzer deleted the repo-status-e2e branch May 13, 2026 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

repo.state() returns Clean when actually dirty

3 participants