include cfmakeraw definition for target_os = nto #4704
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross35
previously requested changes
Sep 22, 2025
Contributor
tgross35
left a comment
tgross35
left a comment
There was a problem hiding this comment.
Looks mostly good except for the noted exception, thanks for including links. Cc target maintainers @flba-eb @jonathanpallant.
mounten
force-pushed
the
nto-add-cfmakeraw-definition
branch
2 times, most recently
from
5aa6ccd to
baf718d
Compare
Contributor
|
Change makes sense, thanks! |
JohnTitor
force-pushed
the
nto-add-cfmakeraw-definition
branch
from
baf718d to
6b41975
Compare
JohnTitor
force-pushed
the
nto-add-cfmakeraw-definition
branch
from
6b41975 to
ba6c97c
Compare
JohnTitor
dismissed
tgross35’s stale review
The review comment has been resolved.
tgross35
added
the
stable-nominated
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 3, 2025
(backport <rust-lang#4704>) (cherry picked from commit 8423131)
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 3, 2025
(backport <rust-lang#4704>) (cherry picked from commit 6e1b073)
Contributor
|
@mounten just fyi, your commit email (as shown in e.g. https://github.com/rust-lang/libc/commit/443576a3177fd612885cc2c3c532f91b0dcfbb83.patch) doesn't seem to be linked to your GH account, so your profile isn't showing up as the commit author. Not a problem on our end of course, just something you might want to fix. |
Merged
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 3, 2025
(backport <rust-lang#4704>) (cherry picked from commit 8423131)
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 3, 2025
(backport <rust-lang#4704>) (cherry picked from commit 6e1b073)
tgross35
added
stable-applied
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
apparently cfmakeraw was not included for target_os = "nto".
Definition of cfmakeraw for nto-qnx:
https://www.qnx.com/developers/docs/7.1/index.html#com.qnx.doc.neutrino.lib_ref/topic/c/cfmakeraw.html
https://www.qnx.com/developers/docs/8.0/com.qnx.doc.neutrino.lib_ref/topic/c/cfmakeraw.html