Skip to content

enable musl32_time64 and musl_v1_2_3 for hexagon#4992

Merged
JohnTitor merged 1 commit intorust-lang:mainfrom
androm3da:bcain/musl32_time64
Feb 27, 2026
Merged

enable musl32_time64 and musl_v1_2_3 for hexagon#4992
JohnTitor merged 1 commit intorust-lang:mainfrom
androm3da:bcain/musl32_time64

Conversation

@androm3da
Copy link
Contributor

Hexagon musl uses 64-bit time_t (__USE_TIME_BITS64), so add it to MUSL_REDIR_TIME64_ARCHES and force musl_v1_2_3 since hexagon only exists with recent musl. Without this, time_t is c_long (4 bytes) causing a 24-byte stack buffer overflow on fstat() calls.

Description

Sources

musl https://github.com/quic/musl/releases/tag/hexagon-v1.2.4-dec-2025

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

@rustbot label +stable-nominated

Hexagon musl uses 64-bit time_t (__USE_TIME_BITS64), so add it to
MUSL_REDIR_TIME64_ARCHES and force musl_v1_2_3 since hexagon only
exists with recent musl. Without this, time_t is c_long (4 bytes)
causing a 24-byte stack buffer overflow on fstat() calls.
@rustbot rustbot added S-waiting-on-review stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Feb 24, 2026
Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JohnTitor JohnTitor added this pull request to the merge queue Feb 27, 2026
Merged via the queue into rust-lang:main with commit 0a15ee8 Feb 27, 2026
51 checks passed
JohnTitor pushed a commit to JohnTitor/libc that referenced this pull request Mar 8, 2026
Hexagon musl uses 64-bit time_t (__USE_TIME_BITS64), so add it to
MUSL_REDIR_TIME64_ARCHES and force musl_v1_2_3 since hexagon only
exists with recent musl. Without this, time_t is c_long (4 bytes)
causing a 24-byte stack buffer overflow on fstat() calls.

(backport <rust-lang#4992>)
(cherry picked from commit 0a15ee8)
@JohnTitor JohnTitor mentioned this pull request Mar 8, 2026
github-merge-queue bot pushed a commit that referenced this pull request Mar 8, 2026
Hexagon musl uses 64-bit time_t (__USE_TIME_BITS64), so add it to
MUSL_REDIR_TIME64_ARCHES and force musl_v1_2_3 since hexagon only
exists with recent musl. Without this, time_t is c_long (4 bytes)
causing a 24-byte stack buffer overflow on fstat() calls.

(backport <#4992>)
(cherry picked from commit 0a15ee8)
@JohnTitor JohnTitor added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Mar 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stable-applied This PR has been cherry-picked to libc's stable release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants