feat: add back support for GNU Windows x86 in CI#5050
Merged
JohnTitor merged 1 commit intorust-lang:mainfrom Apr 10, 2026
Merged
feat: add back support for GNU Windows x86 in CI#5050JohnTitor merged 1 commit intorust-lang:mainfrom
JohnTitor merged 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
A-CI
After having tested out GNU on Windows x86, it seemed like the only issue was related to a wrongly aligned/sized `max_align_t`. This has been fixed, and the test suite seems to be running just fine in CI now for the above platform/environment. There were also some environment variables in CI that seemed to be set for the purposes of changing the Mingw toolchain set up, but that weren't truly being used as the job that ran the script that used those was being triggered earlier in the CI pipeline. Because CI logs seem to reveal this has been the case for some time, this has also been altogether removed.
dybucc
force-pushed
the
reincorporate-windowsx86gnu-to-ci
branch
from
0a1f21f to
8229880
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Contributor
Author
|
Just run CI on my fork with this exact same branch and there were no issues. I Maybe running CI again should solve it. |
JohnTitor
approved these changes
Apr 10, 2026
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Apr 13, 2026
After having tested out GNU on Windows x86, it seemed like the only issue was related to a wrongly aligned/sized `max_align_t`. This has been fixed, and the test suite seems to be running just fine in CI now for the above platform/environment. There were also some environment variables in CI that seemed to be set for the purposes of changing the Mingw toolchain set up, but that weren't truly being used as the job that ran the script that used those was being triggered earlier in the CI pipeline. Because CI logs seem to reveal this has been the case for some time, this has also been altogether removed. (backport <rust-lang#5050>) (cherry picked from commit 3a5c5d7)
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 13, 2026
After having tested out GNU on Windows x86, it seemed like the only issue was related to a wrongly aligned/sized `max_align_t`. This has been fixed, and the test suite seems to be running just fine in CI now for the above platform/environment. There were also some environment variables in CI that seemed to be set for the purposes of changing the Mingw toolchain set up, but that weren't truly being used as the job that ran the script that used those was being triggered earlier in the CI pipeline. Because CI logs seem to reveal this has been the case for some time, this has also been altogether removed. (backport <#5050>) (cherry picked from commit 3a5c5d7)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After having tested out GNU on Windows x86, it seemed like the only issue was
related to a wrongly aligned/sized
max_align_t. This has been fixed, and thetest suite seems to be running just fine in CI now for the above
platform/environment.
There were also some environment variables in CI that seemed to be set for the
purposes of changing the Mingw toolchain set up, but that weren't truly being
used as the job that ran the script that used those was being triggered earlier
in the CI pipeline. Because CI logs seem to reveal this has been the case for
some time, this has also been altogether removed.
Sources
max_align_thttps://github.com/mingw-w64/mingw-w64/blob/9b3dd0125792fe94d16cacdc596dbd42fca1b369/mingw-w64-headers/crt/stddef.h#L424-L427
Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI
@rustbot label +stable-nominated