linux_like: Expose statx on all musl versions - #5448
Merged
Conversation
Exposing the constants and the method in itself is not a breaking change, users are responsible for knowing whether they can call the method without running into linker errors, just like on glibc.
Member
|
I think you'll need to update the test build.rs to skip these |
Contributor
Author
|
I'm slightly confused why this passes tests in CI... |
Contributor
Author
|
Ah: we unconditionally skip |
Contributor
Author
|
Found a few issues with statx on musl in the process of this, will enable the checks and fix them in this PR |
musl uses different types for the statx fields than the Linux kernel headers, most notably its own uint64_t which is an unsigned long rather than an unsigned long long, so the __u64 definitions would be incompatible from ctest's perspective.
Gelbpunkt
force-pushed
the
musl-statx-always
branch
from
August 30, 2026 21:28
7349568 to
b794453
Compare
With this, we now actually test e.g. statx in libc-test on newer musl versions.
Gelbpunkt
force-pushed
the
musl-statx-always
branch
from
August 30, 2026 21:45
b794453 to
71c0057
Compare
Contributor
Author
|
For |
tgross35
added
the
stable-nominated
tgross35
approved these changes
Aug 31, 2026
4 tasks
Contributor
Author
|
@rustbot label +stable-nominated |
Contributor
Author
|
oh nevermind, you already took care of that :) |
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Sep 4, 2026
Exposing the constants and the method in itself is not a breaking change, users are responsible for knowing whether they can call the method without running into linker errors, just like on glibc. (backport <rust-lang#5448>) (cherry picked from commit 823b37f)
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Sep 4, 2026
musl uses different types for the statx fields than the Linux kernel headers, most notably its own uint64_t which is an unsigned long rather than an unsigned long long, so the __u64 definitions would be incompatible from ctest's perspective. (backport <rust-lang#5448>) (cherry picked from commit d2b8ca1)
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Sep 4, 2026
With this, we now actually test e.g. statx in libc-test on newer musl versions. (backport <rust-lang#5448>) (cherry picked from commit bd63612)
Merged
tgross35
added
stable-applied
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposing the constants and the method in itself is not a breaking change, users are responsible for knowing whether they can call the method without running into linker errors, just like on glibc.