Fix deprecation warning for compare_and_swap in atomics.md #519
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The current example code triggers the following deprecation warning in recent Rust versions:
Changes:
This PR replaces the deprecated
compare_and_swapwithcompare_exchange:Technical Note on
compare_exchangevscompare_exchange_weak: Whilecompare_exchange_weakis often preferred in loop scenarios for potential performance gains on certain architectures, I have opted for the standardcompare_exchangehere. This maintains exact semantic parity with the original example and avoids the need for additional explanations regarding "spurious failures," keeping the focus on memory ordering as intended in the nomicon.The
compare_and_swapmethod is deprecated in favor ofcompare_exchange. This update usesOrdering::Acquirefor success andOrdering::Relaxedfor failure, which is appropriate for a spinlock acquire loop.