Fix rule IDs not following the header hierarchy - #2343
Merged
traviscross merged 1 commit intoAug 30, 2026
Conversation
For rule identifiers, we follow the header hierarchy. Where there are related rules but no header, we use a dash rather than a dot as the separator. There were some rule identifiers that used a dot instead. Aside from consistency, this is a problem for how we cite rules in `rustc` tests. We lint against citations of interior rules; misusing dot separation creates interior rules that still need to be cited. Let's fix these.
rustbot
added
the
S-waiting-on-review
traviscross
enabled auto-merge
August 30, 2026 07:52
rustbot
removed
the
S-waiting-on-review
This was referenced Aug 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For rule identifiers, we follow the header hierarchy. Where there are related rules but no header, we use a dash rather than a dot as the separator. There were some rule identifiers that used a dot instead. Aside from consistency, this is a problem for how we cite rules in
rustctests. We lint against citations of interior rules; misusing dot separation creates interior rules that still need to be cited.Let's fix these.