Skip to content

fix: Use the official npm mirror for all VS Code dependencies#21985

Merged
lnicola merged 1 commit intorust-lang:masterfrom
Wilfred:npm_mirror
Apr 7, 2026
Merged

fix: Use the official npm mirror for all VS Code dependencies#21985
lnicola merged 1 commit intorust-lang:masterfrom
Wilfred:npm_mirror

Conversation

@Wilfred
Copy link
Copy Markdown
Contributor

@Wilfred Wilfred commented Apr 7, 2026

c420e48 changed a few packages to be installed from npmmirror.com rather than npmjs.org. This is harmless (there's a SHA512 hash to confirm integrity) but it prevents building the VS Code extension in locked down environments that only permit official package repositories.

It looks like npmmirror.com is an unofficial mirror run by Taobao (it replaced npm.taobao.org) and it can lag behind the official npm repository.

c420e48 changed a few packages to be
installed from npmmirror.com rather than npmjs.org. This is
harmless (there's a SHA512 hash to confirm integrity) but it prevents
building the VS Code extension in locked down environments that only
permit official package repositories.

It looks like npmmirror.com is an unofficial mirror run by Taobao (it
replaced npm.taobao.org) and it can lag behind the official npm
repository.
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 7, 2026
@lnicola
Copy link
Copy Markdown
Member

lnicola commented Apr 7, 2026

This is what npm update @vscode/vsce ovsx produced, I was also confused about the domain, but IIRC it was already used in the lockfile.

Did you just replace the URLs?

@Wilfred
Copy link
Copy Markdown
Contributor Author

Wilfred commented Apr 7, 2026

I did just replace the URLs and confirm that I could still build the extension, yep.

@Wilfred
Copy link
Copy Markdown
Contributor Author

Wilfred commented Apr 7, 2026

@lnicola do you have anything in ~/.npmrc by any chance?

@lnicola
Copy link
Copy Markdown
Member

lnicola commented Apr 7, 2026

I see, looks like I do.

@lnicola lnicola enabled auto-merge April 7, 2026 11:36
@lnicola lnicola disabled auto-merge April 7, 2026 19:46
@lnicola lnicola enabled auto-merge April 7, 2026 19:46
@lnicola lnicola added this pull request to the merge queue Apr 7, 2026
Merged via the queue into rust-lang:master with commit 32ab058 Apr 7, 2026
33 of 35 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants