merge hir_def::hir::Expr::Unsafe into Expr::Block - #23271
Merged
Conversation
`body` is no longer a neighbouring module, but rather a child of `expr_store`
rustbot
added
the
S-waiting-on-review
Contributor
Author
There's an assert at rust-analyzer/crates/hir-def/src/hir.rs Line 397 in 4c34524 which doesn't fail, so apparently not |
A lot of callsites handled these variants similarly, so this ended up simplifying things.
ada4a
force-pushed
the
push-xporswkztpmn
branch
from
September 1, 2026 13:19
e9f052a to
36ac7e2
Compare
ChayimFriedman2
approved these changes
Sep 1, 2026
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A lot of callsites handled these variants similarly, so this ended up simplifying things.