Respect inline allows in needless_pass_by_value - #17665
Merged
Jarcho merged 1 commit intoSep 1, 2026
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
rustbot
added
S-waiting-on-community-reviews
Collaborator
|
Thanks for the pull request, and welcome! You should hear from one of our reviewers after this PR gets at least 2 reviews from the community. Please see the contribution instructions for more information. |
Jarcho
approved these changes
Aug 31, 2026
CommanderStorm
approved these changes
Aug 31, 2026
rustbot
removed
the
S-waiting-on-community-reviews
Collaborator
|
r? @llogiq rustbot has assigned @llogiq for the project review. Use Why was this reviewer chosen?The reviewer was selected based on:
|
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17664
Make
needless_pass_by_valueemit diagnostics using theHirIdof the function argument. This ensures inline#[allow(clippy::needless_pass_by_value)]attributes on arguments suppress the corresponding diagnostic.Added a UI regression test for an allowed
Stringargument.changelog: [
needless_pass_by_value]: Respect inline#[allow]attributes on function arguments.