Open
Conversation
Hard coding a default fallback creates a problem for many use cases. Short of creating an unwanted config file in projects I don't have a say in, I can't make it stop reformatting files with the wrong edition. Furthermore this makes it impossible for users to set their own default fallback via the g:rustfmt_options setting because it will not accept the edition argument being specified more than once. The upstream rustfmt binary has its own fallback logic, by default we should just let it use it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #531
Hard coding a default fallback creates a problem for many use cases. Short of creating an unwanted config file in projects I don't have a say in, I can't make it stop reformatting files with the wrong edition. Furthermore this makes it impossible for users to set their own default fallback via the g:rustfmt_options setting because it will not accept the edition argument being specified more than once. The upstream rustfmt binary has its own fallback logic, by default we should just let it use it.