Unrolled build for #149443

Rollup merge of #149443 - reddevilmidzy:t6, r=Kivooeo

Tidying up UI tests [6/N]

> [!NOTE]
> Intermediate commits are intended to help review, but will be squashed add comment commit prior to merge.

part of #133895

removed directory  `tests/ui/trait-objects`,  `tests/ui/for`, `tests/ui/warnings`

`trait-objects` -> `traits/object`
`for` -> `for-loop-while` (except `for/issue-20605.rs` test. this relocated to `traits/dyn-iterator-deref-in-for-loop.rs`)
`warnings` -> `resolve`, `entry-point`

r? Kivooeo

Author: rust-timer

src/tools/tidy/src/issues.txt

@@ -1014,7 +1014,6 @@ ui/for-loop-while/issue-1257.rs
 ui/for-loop-while/issue-2216.rs
 ui/for-loop-while/issue-51345.rs
 ui/for-loop-while/issue-69841.rs
-ui/for/issue-20605.rs
 ui/foreign/issue-74120-lowering-of-ffi-block-bodies.rs
 ui/foreign/issue-91370-foreign-fn-block-impl.rs
 ui/foreign/issue-99276-same-type-lifetimes.rs

tests/ui/README.md

@@ -573,12 +573,6 @@ Exercises the `format!` macro.
 
 A broad category of tests on functions.
 
-## `tests/ui/for/`: `for` keyword
-
-Tests on the `for` keyword and some of its associated errors, such as attempting to write the faulty pattern `for _ in 0..1 {} else {}`.
-
-**FIXME**: Should be merged with `ui/for-loop-while`.
-
 ## `tests/ui/force-inlining/`: `#[rustc_force_inline]`
 
 Tests for `#[rustc_force_inline]`, which will force a function to always be labelled as inline by the compiler (it will be inserted at the point of its call instead of being used as a normal function call.) If the compiler is unable to inline the function, an error will be reported. See <https://github.com/rust-lang/rust/pull/134082>.
@@ -1521,10 +1515,6 @@ Tests on `enum` variants.
 
 **FIXME**: Contains a single test described as "Check that rustc accepts various version info flags.", should be rehomed.
 
-## `tests/ui/warnings/`
-
-**FIXME**: Contains a single test on non-explicit paths (`::one()`). Should be rehomed probably to `tests/ui/resolve/`.
-
 ## `tests/ui/wasm/`
 
 These tests target the `wasm32` architecture specifically. They are usually regression tests for WASM-specific bugs which were observed in the past.

tests/ui/warnings/hello-world.rs renamed to tests/ui/entry-point/hello-world.rs

@@ -1,4 +1,5 @@
-// E0277 should point exclusively at line 6, not the entire for loop span
+//! Tests that the E0277 error span, generated by the `for` loop desugaring,
+//! points exclusively to the loop header expression and not the full loop block.
 
 fn main() {
     for c in "asdf" {

tests/ui/for/for-c-in-str.rs renamed to tests/ui/for-loop-while/for-c-in-str.rs

@@ -1,5 +1,5 @@
 error[E0277]: `&str` is not an iterator
-  --> $DIR/for-c-in-str.rs:4:14
+  --> $DIR/for-c-in-str.rs:5:14
    |
 LL |     for c in "asdf" {
    |              ^^^^^^ `&str` is not an iterator; try calling `.chars()` or `.bytes()`

tests/ui/for/for-c-in-str.stderr renamed to tests/ui/for-loop-while/for-c-in-str.stderr

@@ -0,0 +1,21 @@
+//! Tests that a struct with a `next` method but without the `Iterator` trait
+//! implementation yields an error in a `for` loop.
+
+struct MyStruct {
+    x: isize,
+    y: isize,
+}
+
+impl MyStruct {
+    fn next(&mut self) -> Option<isize> {
+        Some(self.x)
+    }
+}
+
+pub fn main() {
+    let mut bogus = MyStruct { x: 1, y: 2 };
+    for x in bogus {
+        //~^ ERROR `MyStruct` is not an iterator
+        drop(x);
+    }
+}