-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
Open
Labels
A-compiletestArea: The compiletest test runnerArea: The compiletest test runnerC-bugCategory: This is a bug.Category: This is a bug.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Description
For a test with many revisions...
//@ revisions: x64 x64_win i686 aarch64 arm riscv32 riscv64
... one currently has to write annotations like this:
extern "aapcs" fn aapcs() {}
//[x64]~^ ERROR is not a supported ABI
//[i686]~^^ ERROR is not a supported ABI
//[aarch64]~^^^ ERROR is not a supported ABI
//[riscv32]~^^^^ ERROR is not a supported ABI
//[riscv64]~^^^^^ ERROR is not a supported ABI
//[x64_win]~^^^^^^ ERROR is not a supported ABI
That is quite painful to write and maintain. It would be much nicer if I could write this:
extern "aapcs" fn aapcs() {}
//[x64]~^ ERROR is not a supported ABI
//[i686]~| ERROR is not a supported ABI
//[aarch64]~| ERROR is not a supported ABI
//[riscv32]~| ERROR is not a supported ABI
//[riscv64]~| ERROR is not a supported ABI
//[x64_win]~| ERROR is not a supported ABI
However, that does not work: the filtering of revisions seems to happen before the | logic for "same line as previous annotation" is applied. Would be nice if that could be changed. :)
fmeasefmease
Metadata
Metadata
Assignees
Labels
A-compiletestArea: The compiletest test runnerArea: The compiletest test runnerC-bugCategory: This is a bug.Category: This is a bug.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.