Regression affecting `static-init` versions 1.0.1-1.0.3: "failed to resolve: use of unresolved module or unlinked crate `parking_lot`"

[theemathas]

[INFO] [stdout] error[E0433]: failed to resolve: use of unresolved module or unlinked crate `parking_lot`
[INFO] [stdout]    --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/static_init-1.0.3/src/lazy_sequentializer.rs:336:13
[INFO] [stdout]     |
[INFO] [stdout] 336 |         use parking_lot::lock_api::GetThreadId;
[INFO] [stdout]     |             ^^^^^^^^^^^ use of unresolved module or unlinked crate `parking_lot`
[INFO] [stdout]     |
[INFO] [stdout]     = help: if you wanted to use a crate named `parking_lot`, use `cargo add parking_lot` to add it to your `Cargo.toml`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] error[E0433]: failed to resolve: use of unresolved module or unlinked crate `parking_lot`
[INFO] [stdout]    --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/static_init-1.0.3/src/lazy_sequentializer.rs:371:21
[INFO] [stdout]     |
[INFO] [stdout] 371 |                 use parking_lot::lock_api::GetThreadId;
[INFO] [stdout]     |                     ^^^^^^^^^^^ use of unresolved module or unlinked crate `parking_lot`
[INFO] [stdout]     |
[INFO] [stdout]     = help: if you wanted to use a crate named `parking_lot`, use `cargo add parking_lot` to add it to your `Cargo.toml`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] error[E0433]: failed to resolve: use of unresolved module or unlinked crate `parking_lot`
[INFO] [stdout]    --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/static_init-1.0.3/src/lazy_sequentializer.rs:338:13
[INFO] [stdout]     |
[INFO] [stdout] 338 |             parking_lot::RawThreadId.nonzero_thread_id().into(),
[INFO] [stdout]     |             ^^^^^^^^^^^ use of unresolved module or unlinked crate `parking_lot`
[INFO] [stdout]     |
[INFO] [stdout]     = help: if you wanted to use a crate named `parking_lot`, use `cargo add parking_lot` to add it to your `Cargo.toml`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] error[E0433]: failed to resolve: use of unresolved module or unlinked crate `parking_lot`
[INFO] [stdout]    --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/static_init-1.0.3/src/lazy_sequentializer.rs:372:26
[INFO] [stdout]     |
[INFO] [stdout] 372 |                 if id == parking_lot::RawThreadId.nonzero_thread_id().into() {
[INFO] [stdout]     |                          ^^^^^^^^^^^ use of unresolved module or unlinked crate `parking_lot`
[INFO] [stdout]     |
[INFO] [stdout]     = help: if you wanted to use a crate named `parking_lot`, use `cargo add parking_lot` to add it to your `Cargo.toml`

• https://crater-reports.s3.amazonaws.com/beta-1.93-4/beta-2025-12-22/reg/addr_of-0.1.4/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.93-4/beta-2025-12-22/reg/aerr-0.2.8/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.93-4/beta-2025-12-22/reg/async_wrap-0.1.10/log.txt
• Many others

This regression appears to affect the static-init crate versions 1.0.1-1.0.3, when built with debug_assertions on.

Explanation of the regression (Edit: This explanation is wrong), according to @cuviper, copied from zulip:

• static-init's feature "debug_order" enables parking-lot
• the code that uses it is gated on cfg(debug_mode) (not feature)
• the build script sets cfg "debug_mode" for feature "debug_order" or for debug_assertions, until 1.0.4 removed the latter
• thus it was trying to use parking-lot in all debug builds until 1.0.4 fixed that

and I think it's clearly the intention of #149273 that they shouldn't have been able to use parking-lot implicitly before

[apiraino]

cc @bjorn3 @petrochenkov for an opinion

[bjorn3]

and I think it's clearly the intention of #149273 that they shouldn't have been able to use parking-lot implicitly before

Indeed. In fact I'm surprised it even worked before that PR. parking_lot is not a part of the sysroot.

[theemathas]

(Note: The regression reproduces on Linux, but not Windows.)

Result of running cargo bisect-rustc --start=1.92.0 --end=beta on an empty crate with a dependency of static_init = "=1.0.3":

searched toolchains 6501e64fcb02d22b49d6e59d10a7692ec8095619 through 66428d92bec337ed4785d695d0127276a482278c


********************************************************************************
Regression in ea98522531eec51ee51c393ea4a79af36469d696
********************************************************************************

Attempting to search unrolled perf builds
adding local env GITHUB_TOKEN value to headers in github query
adding local env GITHUB_TOKEN value to headers in github query
ERROR: couldn't find perf build comment

Turns out that the regression actually occurred in #149199. Sorry for the confusion.

[theemathas]

The only relevant-looking cargo commit in that submodule update was rust-lang/cargo#15788.

cc @ Lencerf, @ weihanglo

[theemathas]

Possibly relevant lines from static-init's Cargo.toml:

[dependencies]
parking_lot = {version = "0.11", optional=true}
parking_lot_core = {version = "0.8", optional=true}

[dev-dependencies]
parking_lot = "0.11"

[target.'cfg(not(any(target_os="linux",target_os="android")))'.dependencies]
parking_lot = "0.11"
parking_lot_core = "0.8"