riscv: promote d, e, and f target_features to CfgStableToggleUnstable#156188
riscv: promote d, e, and f target_features to CfgStableToggleUnstable#156188romancardenas wants to merge 3 commits into
Conversation
|
|
This comment has been minimized.
This comment has been minimized.
1397678 to
4e9a3de
Compare
|
Looks good on the test side, thanks. :) Let's nominate this for the @rust-lang/lang. This is about stabilizing the use of the "d", "e", and "f" RISC-V target feature for use in |
|
Blocked waiting on feedback from @Amanieu. |
|
I don't see any harm in stabilizing those. The real issues comes from selectively enabling these on a per-function basis, which this doesn't do. |
|
Team member @traviscross has proposed to merge this. The next step is review by the rest of the tagged team members: No concerns currently listed. Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! cc @rust-lang/lang-advisors: FCP proposed for lang, please feel free to register concerns. |
This PR is a continuation of #155962
It uses the new
CfgStableToggleUnstablestability level for the"d","e", and"f"target_featuresof RISC-V. This way, it will be possible to add conditional code blocks depending on whether the target architecture has FPU, for instance.The PR is related to #150257
r? @RalfJung