rustc: target_features: allow for cfg-only stable target_features#155962
Open
romancardenas wants to merge 1 commit intorust-lang:mainfrom
Open
rustc: target_features: allow for cfg-only stable target_features#155962romancardenas wants to merge 1 commit intorust-lang:mainfrom
rustc: target_features: allow for cfg-only stable target_features#155962romancardenas wants to merge 1 commit intorust-lang:mainfrom
Conversation
Collaborator
|
rustbot has assigned @nikomatsakis. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Collaborator
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new stabilization level for
target_features:CfgOnlyStable. The motivation is allowing the Rust compiler to exposetarget_featuresof targets so users can usecfg(target_feature = "feature")for conditional blocks depending on target features. However,CfgOnlyStablecannot be used for#[target_feature(enable = "feature")], as this is still considered unstable. Accordingly, the compiler will still raise an error if these expressions are used on stable.This PR relates partially to #150257. As discussed, for RISC-V targets, having the
"d","e", and"f"target features exposed will allow baremetal developers to adapt the code depending on the target's properties.r? @RalfJung