std::getopts::opts_present() is broken

[illuloid]

It appears that opts_present() as it is now is broken. It calls find_opt() for each option string and returns true as soon as result is matched against Some(_), but find_opt() returns Some(i) (i being the index of the opt in the Matches.opts vector) when an option is legit (regardless of it being matched). This leads to opts_present() returning true always unless one of the options in the input vector is absent from Matches.opts. Test suite works because it is tested true against options that have been specified, and false against illegal options, but there is no test for optional arguments that have not been specified in the command line. Calling opt_present() instead of opts_present() for each string in vector works as expected.

TL;DR: opts_present() behaves as if it were named opts_matchable().

[catamorphism]

Do you have a test that shows the behavior you're describing?

[illuloid]

extern mod std;
use std::getopts::{optflag, getopts, opts_present, opt_present};

fn main() {
        let opts = ~[optflag("h"), optflag("t"), optflag("help"),
                     optflag("tandy")];

        match getopts(os::args(), opts) {
                Ok(ref matches) => {
                        // valid args
                        let mut test = ~[~"help", ~"h", ~"tandy", ~"t"];
                        for test.each | &x | {
                                io::println(fmt!("%8s: opt_present: %5?, opts_present: %5?",
                                                x, opt_present(matches, x), opts_present(matches, ~[x])));
                        }
                        io::print("\n");

                        // invalid args
                        test = ~[~"whatever", ~"w"];
                        for test.each | &x | {
                                io::println(fmt!("%8s: opts_present: %5?", x,
                                                opts_present(matches, ~[x])));
                        }
                        // (should fail)
                        for test.each | &x | {
                                io::println(fmt!("%8s: opt_present: %5?",
                                                x, opt_present(matches, x)));
                        }
                },
                Err(_) => ()
        };
}

When run, the following is printed:

$ ./opts_present_test -h --tandy
    help: opt_present: false, opts_present:  true
       h: opt_present:  true, opts_present:  true
   tandy: opt_present:  true, opts_present:  true
       t: opt_present: false, opts_present:  true

whatever: opts_present: false
       w: opts_present: false
rust: ~"No option \'whatever\' defined"
rust: task failed at 'explicit failure', /Users/illo/libexec/rust-copy/src/libstd/getopts.rs:351

(in the second step, when I test for non-existent opts, I've separated the call to opt_present from the call to opts_present because the former fails (as expected)).

[dim-an]

looks like this issue was fixed in 4f4f69d and not relevant anymore

[huonw]

Fixed as above (includes a test already).