-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
wasm32-unknown-unknown target should not make output executable #65872
Copy link
Copy link
Open
Labels
C-enhancementCategory: An issue proposing an enhancement or a PR with one.Category: An issue proposing an enhancement or a PR with one.O-wasmTarget: WASM (WebAssembly), http://webassembly.org/Target: WASM (WebAssembly), http://webassembly.org/T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Metadata
Metadata
Assignees
Labels
C-enhancementCategory: An issue proposing an enhancement or a PR with one.Category: An issue proposing an enhancement or a PR with one.O-wasmTarget: WASM (WebAssembly), http://webassembly.org/Target: WASM (WebAssembly), http://webassembly.org/T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Type
Fields
Give feedbackNo fields configured for issues without a type.
The wasm32-unknown-unknown target sets the executable bit on the compiled
.wasmfile. Most uses of wasm don't execute the wasm file directly, and without special configuration (such as binfmt-misc on Linux), most operating systems can't directly run wasm files. Furthermore, the executable bit set on the output tends to get checked into git repositories.For the wasm32-unknown-unknown target, we should not set the executable bit on the output file.