Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coverage: Rename the run-coverage test mode to coverage-run #117700

Merged
merged 1 commit into from Nov 8, 2023

Conversation

Zalathar
Copy link
Contributor

@Zalathar Zalathar commented Nov 8, 2023

Follow-up to #117484 (comment).

Renaming this test mode to coverage-run makes it more consistent with the coverage-map mode and the shared tests/coverage test directory.


@rustbot label +A-code-coverage

This makes it more consistent with the `coverage-map` mode and the shared
`tests/coverage` test directory.
@rustbot
Copy link
Collaborator

rustbot commented Nov 8, 2023

r? @onur-ozkan

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) A-code-coverage Area: Source-based code coverage (-Cinstrument-coverage) labels Nov 8, 2023
@onur-ozkan
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Nov 8, 2023

📌 Commit a573880 has been approved by onur-ozkan

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 8, 2023
fmease added a commit to fmease/rust that referenced this pull request Nov 8, 2023
…ur-ozkan

coverage: Rename the `run-coverage` test mode to `coverage-run`

Follow-up to rust-lang#117484 (comment).

Renaming this test mode to `coverage-run` makes it more consistent with the `coverage-map` mode and the shared `tests/coverage` test directory.

---

`@rustbot` label +A-code-coverage
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 8, 2023
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#114316 (Add AIX platform support document)
 - rust-lang#117531 (rustdoc: properly elide cross-crate host effect args)
 - rust-lang#117650 (Add -Zcross-crate-inline-threshold=yes)
 - rust-lang#117663 (bump some deps)
 - rust-lang#117667 (Document clippy_config in nightly-rustc docs)
 - rust-lang#117698 (Clarify `space_between`)
 - rust-lang#117700 (coverage: Rename the `run-coverage` test mode to `coverage-run`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 7e4ffa9 into rust-lang:master Nov 8, 2023
11 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 8, 2023
Rollup merge of rust-lang#117700 - Zalathar:rename-run-coverage, r=onur-ozkan

coverage: Rename the `run-coverage` test mode to `coverage-run`

Follow-up to rust-lang#117484 (comment).

Renaming this test mode to `coverage-run` makes it more consistent with the `coverage-map` mode and the shared `tests/coverage` test directory.

---

``@rustbot`` label +A-code-coverage
@rustbot rustbot added this to the 1.75.0 milestone Nov 8, 2023
@Zalathar Zalathar deleted the rename-run-coverage branch November 8, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-code-coverage Area: Source-based code coverage (-Cinstrument-coverage) A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants