Skip to content

[perf] alternative approach to #117703 #118136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 9 commits into from
Closed

[perf] alternative approach to #117703 #118136

wants to merge 9 commits into from

Conversation

@lcnr
Copy link
Contributor

@lcnr lcnr commented Nov 21, 2023

@lcnr
Copy link
Contributor Author

lcnr commented Nov 21, 2023

@bors try @rust-timer queue

@rustbot rustbot added A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Nov 21, 2023
@rustbot
Copy link
Collaborator

rustbot commented Nov 21, 2023

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Nov 21, 2023
@bors
Copy link
Collaborator

bors commented Nov 21, 2023

⌛ Trying commit fab367a with merge 009418c...

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 21, 2023
@bors
Auto merge of rust-lang#118136 - lcnr:recursive-async, r=<try>
009418c 
[perf] alternative approach to rust-lang#117703

cc rust-lang#117703

r? `@compiler-errors`
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rustbot
Copy link
Collaborator

rustbot commented Nov 21, 2023

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

@lcnr
Copy link
Contributor Author

lcnr commented Nov 21, 2023

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@bors
Copy link
Collaborator

bors commented Nov 21, 2023

⌛ Trying commit 33e85be with merge 6c239c9...

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 21, 2023
@bors
Auto merge of rust-lang#118136 - lcnr:recursive-async, r=<try>
6c239c9 
[perf] alternative approach to rust-lang#117703

cc rust-lang#117703

r? `@compiler-errors`
@bors
Copy link
Collaborator

bors commented Nov 21, 2023

☀️ Try build successful - checks-actions
Build commit: 6c239c9 (6c239c94dfdf8512684cb447bbba574c624a934b)

@rust-timer

This comment has been minimized.

Sign in to view
@compiler-errors compiler-errors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 21, 2023
compiler-errors
compiler-errors reviewed Nov 21, 2023
View reviewed changes
compiler/rustc_middle/src/values.rs
let mut cycle: VecDeque<_> = cycle_error.cycle.iter().collect();

let guar = 'search: {
for _ in 0..cycle.len() {
Copy link
Member

@compiler-errors compiler-errors Nov 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the purpose of this for loop if you're just using 0 below?

compiler/rustc_middle/src/values.rs
}
break 'search diag.emit();
} else {
cycle.rotate_left(1);
Copy link
Member

@compiler-errors compiler-errors Nov 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh lol, interesting approach.

@rust-timer
Copy link
Collaborator

rust-timer commented Nov 22, 2023

Finished benchmarking commit (6c239c9): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 4.8% [0.4%, 8.8%] 4
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.6% [0.7%, 4.8%] 4
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.7% [-5.4%, -1.5%] 4
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 7.3% [2.9%, 10.6%] 3
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 673.833s -> 675.717s (0.28%)
Artifact size: 313.76 MiB -> 313.75 MiB (-0.00%)

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Nov 22, 2023
@lcnr lcnr closed this Nov 24, 2023
@lcnr lcnr mentioned this pull request Nov 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@compiler-errors compiler-errors compiler-errors left review comments

Assignees

@compiler-errors compiler-errors

Labels

A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) perf-regression Performance regression. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@lcnr @rustbot @rust-timer @bors @rust-log-analyzer @compiler-errors