Skip to content

prevent line number from being copied in chrome #146877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 23, 2025
Merged

prevent line number from being copied in chrome #146877

merged 1 commit into from
Sep 23, 2025
+18 −7

Conversation

el-ev
Copy link
Contributor

@el-ev el-ev commented Sep 22, 2025 •
edited by rustbot
Loading

Fix the issue where line numbers are copied along with code in Chrome

@rustbot
Copy link
Collaborator

rustbot commented Sep 22, 2025

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @jsha, @lolbinarycat

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Sep 22, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 22, 2025

r? @GuillaumeGomez

rustbot has assigned @GuillaumeGomez.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@fmease
Copy link
Member

fmease commented Sep 22, 2025

It'd be worthwhile to investigate if this is a Chrome bug or a Firefox one (i.e., what does the spec say?) and find the corresp. upstream ticket to link to.

@el-ev
Copy link
Contributor Author

el-ev commented Sep 22, 2025

Submitted an issue report to Chromium: https://issues.chromium.org/issues/446539520

@lolbinarycat
Copy link
Contributor

The whole "copy" event handler has a comment saying it's for firefox, probably want to move or rewrite that so it makes more sense. Something like "workaround for multiple browser-specific bugs". Also I think it would make sense to link to the chrome bug report like we do with the firefox bug report.

@el-ev
Copy link
Contributor Author

el-ev commented Sep 23, 2025

Updated the comment.

@GuillaumeGomez
Copy link
Member

Thanks!

@bors r=fmease,lolbinarycat,GuillaumeGomez

@GuillaumeGomez
Copy link
Member

@bors rollup

@bors
Copy link
Collaborator

bors commented Sep 23, 2025

📌 Commit 9ae7aef has been approved by fmease,lolbinarycat,GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 23, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 23, 2025
Merged
bors added a commit that referenced this pull request Sep 23, 2025
@bors
Auto merge of #146938 - matthiaskrgr:rollup-y06ggfz, r=matthiaskrgr
975e6c8 
Rollup of 10 pull requests

Successful merges:

 - #146632 (Fix uses of "adaptor")
 - #146731 (test: Use SVG for terminal url test)
 - #146775 (fixes for numerous clippy warnings)
 - #146784 ([win] Use find-msvc-tools instead of cc to find the linker and rc on Windows)
 - #146799 (Fix a dangling reference in `rustc_thread_pool`)
 - #146802 (mbe: Simplifications and refactoring)
 - #146806 (add private module override re-export test)
 - #146827 (Linker-plugin-based LTO: update list of good combinations (inc. beta + nightly))
 - #146875 (tests/run-make/crate-loading: Rename source files for clarity)
 - #146877 (prevent line number from being copied in chrome)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 8e21b89 into rust-lang:master Sep 23, 2025
10 checks passed
rust-timer added a commit that referenced this pull request Sep 23, 2025
@rust-timer
Unrolled build for #146877
8846300 
Rollup merge of #146877 - el-ev:issue146816, r=fmease,lolbinarycat,GuillaumeGomez

prevent line number from being copied in chrome

- Closes #146816

Fix the issue where line numbers are copied along with code in Chrome
@rustbot rustbot added this to the 1.92.0 milestone Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@GuillaumeGomez GuillaumeGomez

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.
Projects
None yet
Milestone
1.92.0
Development

Successfully merging this pull request may close these issues.

copying multiple source code lines from rustdoc also copies line numbers
6 participants
@el-ev @rustbot @fmease @lolbinarycat @GuillaumeGomez @bors