Convert impossible cases in macro resolution into assertions #147412
Merged
+22
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
yaahc
commented
Oct 6, 2025
petrochenkov
reviewed
Oct 7, 2025
petrochenkov
added
S-waiting-on-author
yaahc
force-pushed
the
macro-res-assertions
branch
2 times, most recently
from
a2dea86 to
2ac850b
Compare
|
@rustbot ready |
rustbot
added
S-waiting-on-review
yaahc
force-pushed
the
macro-res-assertions
branch
from
2ac850b to
6920a8e
Compare
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Oct 8, 2025
Rollup of 6 pull requests Successful merges: - #144006 (clarify wording of match ergonomics diagnostics (`rust_2024_incompatible_pat` lint and error)) - #147386 (some more `proc_macro` cleanups) - #147412 (Convert impossible cases in macro resolution into assertions) - #147464 (prefer repeat_n() over repeat().take()) - #147469 (Add rustdoc crate name in error) - #147472 (refactor: replace `LLVMRustAtomicLoad/Store` with LLVM built-in functions) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Oct 8, 2025
Rollup merge of #147412 - yaahc:macro-res-assertions, r=petrochenkov Convert impossible cases in macro resolution into assertions associated discussion with `@petrochenkov:` [#t-compiler/help > understanding early name resolution of imports @ 💬](https://rust-lang.zulipchat.com/#narrow/channel/182449-t-compiler.2Fhelp/topic/understanding.20early.20name.20resolution.20of.20imports/near/542936677)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
associated discussion with @petrochenkov: #t-compiler/help > understanding early name resolution of imports @ 💬